Add more comments for clearing Fuzzy Dedup Cache #321
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Praateek <[email protected]>
praateekmahajan
commented
Oct 23, 2024
| @@ -184,7 +184,7 @@ Python API | |||
| from nemo_curator import FuzzyDuplicatesConfig | |||
|
|
|||
| config = FuzzyDuplicatesConfig( | |||
| cache_dir="/path/to/dedup_outputs", | |||
| cache_dir="/path/to/dedup_outputs", # must be cleared between runs | |||
There was a problem hiding this comment.
Line 254 has the tip already, can we add somewhere else too?
There was a problem hiding this comment.
I believe other PR's are tackling some of the documentation changes. The only other place I can think of is: https://github.com/NVIDIA/NeMo-Curator/blob/main/examples/fuzzy_deduplication.py
3 tasks
|
Closing in favor of #330 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a user doesn't clear cache between FuzzyDedup runs they might end up using stale data.
daskprovides anoverwriteargument but we avoid using that, so that GPU time is not wasted in clearing up the filesystem.Checklist